Skip to content

feat: split LogoutListener from AttributeListener#684

Closed
denischilik wants to merge 2 commits into
workstation/6.0-Releasefrom
feature/split-logout-listener
Closed

feat: split LogoutListener from AttributeListener#684
denischilik wants to merge 2 commits into
workstation/6.0-Releasefrom
feature/split-logout-listener

Conversation

@denischilik

Copy link
Copy Markdown

Summary

  • Introduces KitIntegration.LogoutListener as a separate contract from the deprecated AttributeListener.
  • KitManagerImpl.logout() invokes logout() only on kits that implement LogoutListener.
  • All embedded kits that previously implemented AttributeListener now explicitly implement LogoutListener as well.
  • AttributeListenerTestKit implements both interfaces for instrumented tests.

Replaces PR #683 (branch renamed to feature/split-logout-listener).

Introduce KitIntegration.LogoutListener for logout handling; AttributeListener
no longer extends it. KitManagerImpl calls logout() on LogoutListener only.
Embedded kits that implement AttributeListener now explicitly implement
LogoutListener; AttributeListenerTestKit updated accordingly.
@denischilik denischilik requested a review from a team as a code owner March 27, 2026 17:56
@cursor

cursor Bot commented Mar 27, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Medium risk because it changes the kit integration interface contract: logout forwarding now depends on implementing the new KitIntegration.LogoutListener, which could break or alter behavior for any kits that relied on AttributeListener.logout() without updating.

Overview
Introduces a new KitIntegration.LogoutListener interface and removes logout() from the deprecated AttributeListener, decoupling logout handling from user-attribute support.

Updates KitManagerImpl.logout() to invoke logout only on providers implementing LogoutListener, and updates embedded kits plus the AttributeListenerTestKit to explicitly implement LogoutListener so they continue receiving logout callbacks.

Written by Cursor Bugbot for commit ed12758. This will update automatically on new commits. Configure here.

@denischilik denischilik changed the title feat(kits): split LogoutListener from AttributeListener feat: split LogoutListener from AttributeListener Mar 27, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@denischilik denischilik deleted the feature/split-logout-listener branch March 27, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant