Repoint manpage symlinks that point to symlinks#212
Draft
ryandesign wants to merge 1 commit intomacports:masterfrom
Draft
Repoint manpage symlinks that point to symlinks#212ryandesign wants to merge 1 commit intomacports:masterfrom
ryandesign wants to merge 1 commit intomacports:masterfrom
Conversation
MacPorts previously only fixed up manpage symlinks that pointed to real manpage files, but some ports install manpage symlinks that point to other symlinks that then point to real manpage files. The old two-step method of first compressing all manpage files and then fixing up symlinks is replaced with a three-step process that first inventories the man directory, then compresses all manpages, then fixes up symlinks. This ensures that we have a complete and accurate inventory including what each symlink points to before we change anything. Closes: https://trac.macports.org/ticket/61288
Member
|
Do we actually need to do this at all on OS versions capable of hfscompression? |
Contributor
Author
|
If we could rely on hfscompression being available, then you're right, we wouldn't need this. However hfscompression requires the user to install libarchive to use its version of tar; the version provided by the OS hasn't been recent enough. We can't know at the time that we package up the archives on the build servers whether the user has hfscompression enabled. So I think we should continue to gzip-compress manpages as we've been doing. Another reason not to change it now is that some ports may rely on the existing behavior, assuming that the manpages will be gzipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MacPorts previously only fixed up manpage symlinks that pointed to real manpage files, but some ports install manpage symlinks that point to other symlinks that then point to real manpage files.
The old two-step method of first compressing all manpage files and then fixing up symlinks is replaced with a three-step process that first inventories the man directory, then compresses all manpages, then fixes up symlinks. This ensures that we have a complete and accurate inventory including what each symlink points to before we change anything.
Closes: https://trac.macports.org/ticket/61288
This works for me to fix graphviz-devel's dot2gxl.1 symlink but I should do more testing on other types of ports, such as python modules or other ports that install manpages in a nonstandard man directory and then symlink those into the standard man directory.