Make the aclocal.m4 file in base safe to regenerate with aclocal#342
Open
cooljeanius wants to merge 2 commits intomacports:masterfrom
Open
Make the aclocal.m4 file in base safe to regenerate with aclocal#342cooljeanius wants to merge 2 commits intomacports:masterfrom
aclocal#342cooljeanius wants to merge 2 commits intomacports:masterfrom
Conversation
acinclude.m4 and m4/tcl.m4 both have underquoted macros in them, so this commit fixes them by properly quoting them. This also makes aclocal.m4 safe to regenerate with aclocal, which this commit does as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerating aclocal.m4 with
aclocalis a standard part of an autotools workflow. All ofautomake,libtoolize, andgettextizetell you to do it, among others. However, the aclocal.m4 file in base contains some hard-coded macros in it, meaning that if you runaclocal, you're going to overwrite them and then be missing some of the macros you need. This PR fixes that by renaming the existing aclocal.m4 to acinclude.m4, and then fixing the "underquoted macro" warnings thataclocalproduces, so that a new aclocal.m4 can be regenerated safely.Closes: https://trac.macports.org/ticket/38579