Skip to content

Node 12.*/13.* adaption#78

Open
alexander-girsh wants to merge 7 commits intomafintosh:masterfrom
alexander-girsh:node-13-adaption
Open

Node 12.*/13.* adaption#78
alexander-girsh wants to merge 7 commits intomafintosh:masterfrom
alexander-girsh:node-13-adaption

Conversation

@alexander-girsh
Copy link
Copy Markdown

All tests written by the founder are pass on debian/ubuntu via Docker.

Code updates:
Local Context added to calls of Local<Object> .Has() / .Get() / .Set() methods according the docs https://v8docs.nodesource.com/node-12.0/df/d69/classv8_1_1_context.html

.Init()method updated according the API changes.
https://nodejs.org/api/addons.html#addons_context_aware_addons

Parsing options provided from JS in the .Mount( ) method is protected from provided null / undefined value.

Also a simple Dockerfile was added to run compilation / tests from a macosx without the osxfuse.

You can debug this cpp addon with a native VS Code debugger attached. Do not forget to pass --debug option to the node-gyp build command. Any CFLAGS / CXXFLAGS are not needed to do that.

All tests written by the founder are pass.

Local Context added to calls of Local <Object> .Has(), .Get() and .Set() methods. https://v8docs.nodesource.com/node-12.0/df/d69/classv8_1_1_context.html

.Init() method updated according the API changes.
https://nodejs.org/api/addons.html#addons_context_aware_addons

Parsing options provided from JS in the .Mount( ) method is protected from provided null / undefined value.
All tests written by the founder are pass on debian/ubuntu via Docker.

Code updates:
Local Context added to calls of Local <Object> .Has(), .Get() and .Set() methods according the docs https://v8docs.nodesource.com/node-12.0/df/d69/classv8_1_1_context.html

.Init() method updated according the API changes.
https://nodejs.org/api/addons.html#addons_context_aware_addons

Parsing options provided from JS in the .Mount( ) method is protected from provided null / undefined value.

Also a simple Dockerfile was added to  run compilation / tests from a macosx without the osxfuse.

You can debug this cpp addon with a native VS Code debugger attached. Do not forget to pass "--debug"  option to the "node-gyp build" command. Any CFLAGS / CXXFLAGS are not needed to do that.
@frank-dspeed
Copy link
Copy Markdown

this can be closed as it is in https://github.com/direktspeed/node-fuse-bindings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants