[ECL] Implement Trystan's Command - #14216
Merged
Merged
Conversation
theelk801
requested changes
Jan 10, 2026
| } | ||
| } | ||
|
|
||
| class TrystansCommandEffect extends ContinuousEffectImpl { |
Contributor
There was a problem hiding this comment.
an easier way to do this effect is with a OneShotEffect, you can get all the creatures the targeted player controls, create a BoostTargetEffect and use FixedTargets to have it target all of them, add it with game::addEffect, call game.processAction(), and then iterate through each of the creatures and untap them
theelk801
requested changes
Jan 10, 2026
|
|
||
| @Override | ||
| public boolean apply(Game game, Ability source) { | ||
| Player targetPlayer = game.getPlayer(source.getControllerId()); |
Contributor
There was a problem hiding this comment.
this is the controller, not the targeted player
theelk801
requested changes
Jan 11, 2026
|
|
||
| @Override | ||
| public boolean apply(Game game, Ability source) { | ||
| Player targetPlayer = game.getPlayer(source.getFirstTarget()); |
Contributor
There was a problem hiding this comment.
you should use getTargetPointer().getFirst(game,source) in general instead of source.getFirstTarget() but especially here since it's a modal spell
muz
force-pushed
the
ecl_trystans_command
branch
from
January 11, 2026 01:21
efd25a2 to
087e6ad
Compare
theelk801
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.