Make integration test settings overridable per ENV#40526
Open
stollr wants to merge 1 commit intomagento:2.4-developfrom
Open
Make integration test settings overridable per ENV#40526stollr wants to merge 1 commit intomagento:2.4-developfrom
stollr wants to merge 1 commit intomagento:2.4-developfrom
Conversation
This addresses Github issue magento#40525
|
Hi @stollr. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
In the
bootstrap.phpof the integration test framework several settings are derived from the defined constants.But this is very static and unflexible. This PR improves the situation by replacing the values of the constants by environment variables.
Fixed Issues (if relevant)
Manual testing scenarios (*)
TESTS_CLEANUPis set toenabledin your phpunit.xml.distTESTS_CLEANUP=disabled vendor/bin/phpunit -c dev/tests/integration/phpunit.xml.distThis should not trigger a re-installation of Magento in the test database.
Contribution checklist (*)