Skip to content

Make integration test settings overridable per ENV#40526

Open
stollr wants to merge 1 commit intomagento:2.4-developfrom
stollr:overwrite_constants_with_env_in_test_settings
Open

Make integration test settings overridable per ENV#40526
stollr wants to merge 1 commit intomagento:2.4-developfrom
stollr:overwrite_constants_with_env_in_test_settings

Conversation

@stollr
Copy link

@stollr stollr commented Feb 11, 2026

Description (*)

In the bootstrap.php of the integration test framework several settings are derived from the defined constants.

$settings = new \Magento\TestFramework\Bootstrap\Settings($testsBaseDir, get_defined_constants());

But this is very static and unflexible. This PR improves the situation by replacing the values of the constants by environment variables.

$settings = new \Magento\TestFramework\Bootstrap\Settings($testsBaseDir, array_replace(
    get_defined_constants(),
    getenv()
));

Fixed Issues (if relevant)

  1. Fixes Allow overriding constant values of integration test settings per ENV #40525

Manual testing scenarios (*)

  1. Make sure that the TESTS_CLEANUP is set to enabled in your phpunit.xml.dist
  2. Run TESTS_CLEANUP=disabled vendor/bin/phpunit -c dev/tests/integration/phpunit.xml.dist

This should not trigger a re-installation of Magento in the test database.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (not applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 11, 2026

Hi @stollr. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Allow overriding constant values of integration test settings per ENV

2 participants