fix(elasticsearch): add sortOrder to FieldName CompositeResolver items in di.xml#40543
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
…s in di.xml The <type> configuration for CompositeResolver in the FieldName namespace was missing sortOrder attributes on its items, unlike the corresponding virtualType (elasticsearchFieldNameResolver) which correctly defined sortOrder values (10, 20, 30, 40, 50, 100). When a third-party module adds a custom field name resolver to CompositeResolver via di.xml with a sortOrder lower than the default resolver, the sortOrder was not respected because the existing built-in items had no sortOrder to compare against. As a result, custom resolvers were always placed after the default resolver and became unreachable. Added sortOrder attributes (10, 20, 30, 40, 50, 100) to all existing items in the <type> configuration, matching the values used in the elasticsearchFieldNameResolver virtualType. Fixes magento#39895
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
The
<type>configuration forFieldName\Resolver\CompositeResolverinMagento/Elasticsearch/etc/di.xmlwas missingsortOrderattributes on its items, unlike:elasticsearchFieldNameResolvervirtualType (which correctly definedsortOrdervalues: 10, 20, 30, 40, 50, 100)FieldType\Resolver\CompositeResolvertype (which also correctly usessortOrder)When a third-party module adds a custom field name resolver to
CompositeResolverviadi.xmlwith asortOrderlower than 100 (the default resolver), the sort order was not respected because the existing built-in items had nosortOrderto compare against. As a result, custom resolvers were always placed after thedefaultresolver and became unreachable — making it impossible to add custom Elasticsearch field resolvers.Fix: Added
sortOrderattributes (10, 20, 30, 40, 50, 100) to all existing items in the<type>configuration, matching the values used in theelasticsearchFieldNameResolvervirtualType.Related Pull Requests
No related pull requests
Fixed Issues
Fixes #39895
Manual testing scenarios (*)
FieldNameresolver and register it indi.xmlwithsortOrder="31"(betweenpricesortOrder=30 andcategoryNamesortOrder=40)CompositeResolver::getFieldName()is invoked for a matching attributeQuestions or comments
No questions or comments
Contribution checklist (*)
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz