Skip to content

fix(elasticsearch): add sortOrder to FieldName CompositeResolver items in di.xml#40543

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39895-elasticsearch-composite-resolver-sort-order
Open

fix(elasticsearch): add sortOrder to FieldName CompositeResolver items in di.xml#40543
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39895-elasticsearch-composite-resolver-sort-order

Conversation

@lbajsarowicz
Copy link
Contributor

Description (*)

The <type> configuration for FieldName\Resolver\CompositeResolver in Magento/Elasticsearch/etc/di.xml was missing sortOrder attributes on its items, unlike:

  • The elasticsearchFieldNameResolver virtualType (which correctly defined sortOrder values: 10, 20, 30, 40, 50, 100)
  • The FieldType\Resolver\CompositeResolver type (which also correctly uses sortOrder)

When a third-party module adds a custom field name resolver to CompositeResolver via di.xml with a sortOrder lower than 100 (the default resolver), the sort order was not respected because the existing built-in items had no sortOrder to compare against. As a result, custom resolvers were always placed after the default resolver and became unreachable — making it impossible to add custom Elasticsearch field resolvers.

Fix: Added sortOrder attributes (10, 20, 30, 40, 50, 100) to all existing items in the <type> configuration, matching the values used in the elasticsearchFieldNameResolver virtualType.

Related Pull Requests

No related pull requests

Fixed Issues

Fixes #39895

Manual testing scenarios (*)

  1. Create a module with a custom FieldName resolver and register it in di.xml with sortOrder="31" (between price sortOrder=30 and categoryName sortOrder=40)
  2. Verify the custom resolver is called when CompositeResolver::getFieldName() is invoked for a matching attribute
  3. Verify the built-in resolvers still function correctly in their expected order

Questions or comments

No questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

…s in di.xml

The <type> configuration for CompositeResolver in the FieldName namespace
was missing sortOrder attributes on its items, unlike the corresponding
virtualType (elasticsearchFieldNameResolver) which correctly defined
sortOrder values (10, 20, 30, 40, 50, 100).

When a third-party module adds a custom field name resolver to CompositeResolver
via di.xml with a sortOrder lower than the default resolver, the sortOrder
was not respected because the existing built-in items had no sortOrder
to compare against. As a result, custom resolvers were always placed
after the default resolver and became unreachable.

Added sortOrder attributes (10, 20, 30, 40, 50, 100) to all existing
items in the <type> configuration, matching the values used in the
elasticsearchFieldNameResolver virtualType.

Fixes magento#39895
@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P3 May be fixed according to the position in the backlog. labels Feb 24, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Can't add a custom field resolver for ElasticSearch

2 participants