Skip to content

Fix tier price delete() not matching website_id#40557

Open
annv99 wants to merge 2 commits intomagento:2.4-developfrom
annv99:DEV-1321-fix-tier-price-issue
Open

Fix tier price delete() not matching website_id#40557
annv99 wants to merge 2 commits intomagento:2.4-developfrom
annv99:DEV-1321-fix-tier-price-issue

Conversation

@annv99
Copy link

@annv99 annv99 commented Feb 27, 2026

Description (*)

The retrievePriceId() method in TierPriceStorage did not compare website_id when matching tier prices for deletion. When identical tier prices existed across different websites, only the first matching price was resolved, causing delete() to silently skip the rest.

Added website_id to the matching condition so each tier price is uniquely identified.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Tier Price Storage Interface Delete Bug doesn't delete all Tier Prices #37949

Manual testing scenarios (*)

  1. Create a product assigned to multiple websites.
  2. Add identical tier prices (same customer group, qty, price) for each website.
  3. Retrieve all tier prices via TierPriceStorageInterface::get() and pass them to TierPriceStorageInterface::delete().
  4. Verify all tier prices are deleted, not just the first match.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 27, 2026

Hi @annv99. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@annv99
Copy link
Author

annv99 commented Feb 27, 2026

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 3, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Tier Price Storage Interface Delete Bug doesn't delete all Tier Prices

2 participants