Add exception output when fixtures fail#40574
Open
jissereitsma wants to merge 1 commit intomagento:2.4-developfrom
Open
Add exception output when fixtures fail#40574jissereitsma wants to merge 1 commit intomagento:2.4-developfrom
jissereitsma wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @jissereitsma. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
When running Integration Tests and using the new PHP Attributes for defining fixtures (via the
DataFixtureattribute) it might be that a specific data fixture class (likeMagento\Catalog\Test\Fixture\Product) is producing an exception. However, because of the current code in\Magento\TestFramework\Annotation\DataFixtureSetup, the fixture is simply skipped and the exception message never is displayed. This makes it very hard to analyse failed tests.This PR adds a simple
echoto display the exception message. To reproduce this, an Integration Test could be created by making use of the data fixtureMagento\Catalog\Test\Fixture\Product. Next, in the original code of the fixturevendor/magento/module-catalog/Test/Fixture/Product.php, the following could be added to fake an exception:Without this PR in place, the given exception never is displayed, but the fixture is (obviously) not run either. With this PR, the fixture is still not run (obviously), however the exception is displayed.
Contribution checklist (*)