Skip to content

Add exception output when fixtures fail#40574

Open
jissereitsma wants to merge 1 commit intomagento:2.4-developfrom
jissereitsma:patch-3
Open

Add exception output when fixtures fail#40574
jissereitsma wants to merge 1 commit intomagento:2.4-developfrom
jissereitsma:patch-3

Conversation

@jissereitsma
Copy link
Contributor

@jissereitsma jissereitsma commented Mar 5, 2026

Description (*)

When running Integration Tests and using the new PHP Attributes for defining fixtures (via the DataFixture attribute) it might be that a specific data fixture class (like Magento\Catalog\Test\Fixture\Product) is producing an exception. However, because of the current code in \Magento\TestFramework\Annotation\DataFixtureSetup, the fixture is simply skipped and the exception message never is displayed. This makes it very hard to analyse failed tests.

use Magento\Catalog\Test\Fixture\Product as ProductFixture;

#[DataFixture(ProductFixture::class, ['sku' => 'simple-$$$$-001'], as: 'product')]
final class DummyTest extends TestCase
{
}

This PR adds a simple echo to display the exception message. To reproduce this, an Integration Test could be created by making use of the data fixture Magento\Catalog\Test\Fixture\Product . Next, in the original code of the fixture vendor/magento/module-catalog/Test/Fixture/Product.php, the following could be added to fake an exception:

    public function apply(array $data = []): ?DataObject
    {
        throw new \Exception('Product fixture failed with a hack');
    }

Without this PR in place, the given exception never is displayed, but the fixture is (obviously) not run either. With this PR, the fixture is still not run (obviously), however the exception is displayed.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 5, 2026

Hi @jissereitsma. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant