Output script for "Bending the Curve 2" project land use reporting#867
Merged
pvjeetze merged 12 commits intomagpiemodel:developfrom Mar 20, 2026
Merged
Output script for "Bending the Curve 2" project land use reporting#867pvjeetze merged 12 commits intomagpiemodel:developfrom
pvjeetze merged 12 commits intomagpiemodel:developfrom
Conversation
pascal-sauer
approved these changes
Mar 12, 2026
| # outputdir <- NULL | ||
| # # Define arguments that can be read from command line | ||
| # readArgs("outputdir") | ||
| # } |
Contributor
There was a problem hiding this comment.
This should be commented in, right? If not, please delete it.
| suffix <- "firstruns" | ||
| suffix <- "" | ||
|
|
||
| projectName <- "BTC2v04" |
Contributor
There was a problem hiding this comment.
minor comment (literally): capitalization is BtC2 in all other places, while it is a capital T here
Co-authored-by: Pascal Sauer <156898545+pascal-sauer@users.noreply.github.com> Co-authored-by: georg-schroeter <Georg.Schroeter@pik-potsdam.de>
georg-schroeter
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐦 Description of this PR 🐦
🔧 Checklist for PR creator 🔧
If a point is not applicable, check the checkbox anyway and write "non-applicable" next to the checkbox.
Label pull request from the label list.
Self-review own code
magpie4R library has been updated accordingly and backwards compatible where necessary.scenario_config.csvhas been updated accordingly (important ifdefault.cfghas been updated)Document changes
CHANGELOG.mdgoxygen::goxygen()and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"Rscript start.R --> "default"Rscript start.R --> "test runs"Reporting produces no errors and no new warnings
Get two approving reviews (at least one from RSE)
📉 Performance 📈
🚨 Checklist for reviewer 🚨
CHANGELOGis updated correctly