Skip to content

fix(HappyHare): Show spool for bypass empty/full based on loaded - #2438

Merged
meteyou merged 2 commits into
mainsail-crew:developfrom
moggieuk:bypass_spool_fix
Jun 17, 2026
Merged

fix(HappyHare): Show spool for bypass empty/full based on loaded#2438
meteyou merged 2 commits into
mainsail-crew:developfrom
moggieuk:bypass_spool_fix

Conversation

@moggieuk

Copy link
Copy Markdown
Contributor

Description

This PR fixes the spool for the bypass gate and correctly shows filament or not based on whether the extruder is loaded.

Related Tickets & Documents

n/a

Mobile & Desktop Screenshots/Recordings

When loaded shows full, else will be empty spool
Screenshot 2026-02-12 at 2 23 55 PM

[optional] Are there any post-deployment tasks we need to perform?

n/a

@coderabbitai

coderabbitai Bot commented Feb 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 88a0a58d-3110-4e9c-b521-7e93bb5a87d1

📥 Commits

Reviewing files that changed from the base of the PR and between 9eda132 and 528fdaa.

📒 Files selected for processing (1)
  • src/components/panels/Mmu/MmuUnitGateSpool.vue

📝 Walkthrough

Walkthrough

The MMU gate spool component is enhanced to import additional constants (TOOL_GATE_BYPASS, GATE_AVAILABLE, FILAMENT_POS_LOADED) and now includes special logic to handle a TOOL_GATE_BYPASS index case. The gate status determination now checks for loaded filament when the gate index is TOOL_GATE_BYPASS, and defaults to GATE_EMPTY instead of GATE_UNKNOWN. Tooltip validation for spoolId is tightened to require explicit greater-than-zero check.

Changes

MMU Gate Spool Component

Layer / File(s) Summary
TOOL_GATE_BYPASS gate status and tooltip logic
src/components/panels/Mmu/MmuUnitGateSpool.vue
Expanded imports to include TOOL_GATE_BYPASS, GATE_AVAILABLE, and FILAMENT_POS_LOADED constants. Updated status getter to handle TOOL_GATE_BYPASS as a special case, returning GATE_AVAILABLE when filament is loaded, otherwise GATE_EMPTY. Changed default gate status fallback from GATE_UNKNOWN to GATE_EMPTY for non-bypass gates. Refined tooltip spoolId validation from truthy check to explicit > 0 comparison.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A gate that knows when tools will stay,
With bypass magic in its way,
When filament sits just right and true,
The spool knows just what to do! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the bypass gate spool display to show full/empty based on filament loaded state.
Description check ✅ Passed The description clearly explains the fix for the bypass gate spool and includes a screenshot demonstrating the loaded state behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

meteyou
meteyou previously approved these changes Jun 17, 2026
@meteyou meteyou changed the title fix(HappyHare): Show the spool for bypass empty/full based on whether filament is loaded fix(HappyHare): Show spool for bypass empty/full based on loaded Jun 17, 2026
@meteyou
meteyou merged commit 92354ab into mainsail-crew:develop Jun 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants