fix(HappyHare): Show spool for bypass empty/full based on loaded - #2438
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe MMU gate spool component is enhanced to import additional constants (TOOL_GATE_BYPASS, GATE_AVAILABLE, FILAMENT_POS_LOADED) and now includes special logic to handle a TOOL_GATE_BYPASS index case. The gate status determination now checks for loaded filament when the gate index is TOOL_GATE_BYPASS, and defaults to GATE_EMPTY instead of GATE_UNKNOWN. Tooltip validation for spoolId is tightened to require explicit greater-than-zero check. ChangesMMU Gate Spool Component
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This PR fixes the spool for the bypass gate and correctly shows filament or not based on whether the extruder is loaded.
Related Tickets & Documents
n/a
Mobile & Desktop Screenshots/Recordings
When loaded shows full, else will be empty spool

[optional] Are there any post-deployment tasks we need to perform?
n/a