-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix(api): enforce object-level authz on asset/attachment endpoints + WorkspaceAdmin API permissions #8886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fix(api): enforce object-level authz on asset/attachment endpoints + WorkspaceAdmin API permissions #8886
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
da22c82
feat: add WorkspaceAdminOnlyPermission for external API access control
sriramveeraghanta 14f08e2
fix(api): close cross-workspace/cross-project asset IDOR & missing-au…
sriramveeraghanta 8461c37
fix: merge conflicts
sriramveeraghanta 38db42e
fix(api): address PR review + resolve merge conflict in asset duplica…
sriramveeraghanta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from .workspace import WorkspaceAdminOnlyPermission, WorkspaceAdminWriteMemberReadPermission | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Copyright (c) 2023-present Plane Software, Inc. and contributors | ||
| # SPDX-License-Identifier: AGPL-3.0-only | ||
| # See the LICENSE file for details. | ||
|
|
||
| from rest_framework.permissions import BasePermission, SAFE_METHODS | ||
|
|
||
| from plane.db.models import WorkspaceMember | ||
|
|
||
|
|
||
| Admin = 20 | ||
| Member = 15 | ||
|
sriramveeraghanta marked this conversation as resolved.
Outdated
|
||
|
|
||
|
|
||
| class WorkspaceAdminOnlyPermission(BasePermission): | ||
| """ | ||
| Permission class for external APIs that restricts access to workspace admins only. | ||
| """ | ||
|
|
||
|
sriramveeraghanta marked this conversation as resolved.
|
||
| def has_permission(self, request, view): | ||
| if request.user.is_anonymous: | ||
| return False | ||
|
|
||
| return WorkspaceMember.objects.filter( | ||
| member=request.user, | ||
| workspace__slug=view.workspace_slug, | ||
| role=Admin, | ||
| is_active=True, | ||
| ).exists() | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
|
|
||
| class WorkspaceAdminWriteMemberReadPermission(BasePermission): | ||
| """ | ||
| Permission class for external APIs that allows workspace members to read | ||
| but restricts write operations to workspace admins only. | ||
| """ | ||
|
|
||
| def has_permission(self, request, view): | ||
| if request.user.is_anonymous: | ||
| return False | ||
|
|
||
| if request.method in SAFE_METHODS: | ||
| return WorkspaceMember.objects.filter( | ||
| member=request.user, | ||
| workspace__slug=view.workspace_slug, | ||
| role__in=[Admin, Member], | ||
| is_active=True, | ||
| ).exists() | ||
|
|
||
| return WorkspaceMember.objects.filter( | ||
| member=request.user, | ||
| workspace__slug=view.workspace_slug, | ||
| role=Admin, | ||
| is_active=True, | ||
| ).exists() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.