Draft
Conversation
We were using `await` on the compression stream but this meant that somtimes the rest of the HTML document was being loaded before the resources had been inflated. Now, we decompress in a blocking manner by manually pumping the promise so that we eliminate all the async.
The HTML has changed as we've edited the jsinflate file
…ssions The empty test is causing problems when trying to render images as wkhtmltox is refusing to render an empty image.
Our current regression suite checks that the rendered HTML doesn't change. However, sometimes we want to change the HTML (and so will bless the output), but don't expect the rendered _image_ to change. This test makes sure that we are aware of any pixel changes in the image output of pybloqs. Note: This makes the regression testing now _very_ sensitive, particularly to third party changes. We will need to freeze all the versions of our dependencies that we use in order for this to not become unnecessarily noisy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.