Closed
Conversation
DreamMaoMao
force-pushed
the
main
branch
2 times, most recently
from
cfd4249 to
eb06075
Compare
iynaix
reviewed
Feb 7, 2026
nix/hm-modules.nix
Outdated
Comment on lines
+20
to
+23
| output=$(${cfg.package}/bin/mango -c "$out" -p 2>&1 || true) | ||
|
|
||
| if echo "$output" | grep -Fq '[ERROR]:'; then | ||
| echo "$output" |
Contributor
There was a problem hiding this comment.
Suggested change
| output=$(${cfg.package}/bin/mango -c "$out" -p 2>&1 || true) | |
| if echo "$output" | grep -Fq '[ERROR]:'; then | |
| echo "$output" | |
| ${cfg.package}/bin/mango -c "$out" -p |
Contributor
There was a problem hiding this comment.
-p now has a non-zero exit code on validation errors after #639
DreamMaoMao
force-pushed
the
main
branch
2 times, most recently
from
e357c8f to
6b79a43
Compare
Author
|
I think I might have rebased incorrectly |
Author
|
Going to close this pr and open a new one rather than messing with the git history |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will make the derivation fail if the config is incorrect