[@mantine/hooks] use-intersection: Use the last entry from a batched observer callback#9019
Open
greymoth-jp wants to merge 1 commit into
Open
Conversation
…observer callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8509, which fixed the same issue in
use-in-viewport.useIntersectionreads only the first entry from the observer callback:When the callback is delayed across frames (busy main thread, fast scrolling), the browser can queue more than one
IntersectionObserverEntryfor the observed element and deliver them in a single call. The first entry then holds an older state and the last one holds the current state, so the hook can report a staleentry. This is the same situation #8509 describes foruse-in-viewport.The fix mirrors #8509: read the last entry.
I left
use-resize-observeras it is even though it also readsentries[0]: aResizeObserverreports the current size of each target once per delivery instead of accumulating one entry per frame, so its first entry is already the latest.Added a regression test that feeds a mock observer a two-entry batch and checks the hook keeps the last entry. Without the change the test fails because the hook returns the stale first entry.