Use Rails.root to determine if template is local#74
Merged
Conversation
Contributor
|
Thanks @marcoroth! While #56 used to work for me, a dependency change caused things to break and I really appreciate that you're already on top of it |
Owner
Author
|
Great, even better @HashNotAdam! Thanks for confirming! I'm glad this is not going to break your previous setup! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #56
The approach we used in #56 also wasn't quite right, as it wasn't detecting templates in
#{Rails.root}/app/componentssince they weren't part of theview_parts.Instead, let's just consider everything a local template if it's within
Rails.root, which should work for internal engines, packwerk etc.Related marcoroth/herb#1088
Related marcoroth/herb#1132