Fix INT8 calibrator offset indexing#690
Open
xalil8 wants to merge 1 commit intomarcoslucianops:masterfrom
Open
Fix INT8 calibrator offset indexing#690xalil8 wants to merge 1 commit intomarcoslucianops:masterfrom
xalil8 wants to merge 1 commit intomarcoslucianops:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the INT8 calibrator preprocessing for 3-channel input.
calibrator.cppcurrently usesoffsets[3]for the third channel:cv::Scalar(offsets[0] / 255, offsets[1] / 255, offsets[3] / 255)The sample configs define three offsets, so the third value should be
offsets[2].This change only affects the INT8 calibration path.