Feat: recaptcha added #227
Feat: recaptcha added #227akshitarora921 wants to merge 7 commits intomargaritahumanitarian:mainfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/margaritahumanitarian/helpafamily/7hhfbYi2rYxEc2tjUR5ZFHJjHpuw |
|
Need to do 2 things:
|
|
Any update on this? @audreyfeldroy |
|
@akshitarora921 so did we figure out what we're doing with the keys here? |
| SUCCESS_URL = "https://helpafamily.margaritahumanitarian.org/thank-you" | ||
| NEXT_PUBLIC_GMAPS_JS_API_KEY = "<your Google Maps JavaScript API Key here>" | ||
|
|
||
| NEXT_PUBLIC_SITE_KEY=6LcjyaccAAAAAAjE2z6vBhs2tOdhC-t0F2OCMj7z |
There was a problem hiding this comment.
@akshitarora921 So let's get this part figured out and we can get this PR in! :)
There was a problem hiding this comment.
Hey @akshitarora921. So I think what would help a lot is for you to explain what you're doing with these keys.
- Where are they from
- What are they doing
- What we need to do
I've looked into it and it might be better next time for us to get your PR through if you outline what we need to do as a follow up to your work. A list of todos. Here's an example for todos for us:
- Go to recaptha website and generate keys for production
- Use sitekey in code (go into detail)
- Use secret key in server env (go into detail)
This would help a lot.
|
@akshitarora921 if you would rebase your codebase (fetch upstream or go to your forked repo and click fetch) as well so everything is up to date. 🙏 |
| SUCCESS_URL = "https://helpafamily.margaritahumanitarian.org/thank-you" | ||
| NEXT_PUBLIC_GMAPS_JS_API_KEY = "<your Google Maps JavaScript API Key here>" | ||
|
|
||
| NEXT_PUBLIC_SITE_KEY=6LcjyaccAAAAAAjE2z6vBhs2tOdhC-t0F2OCMj7z |
There was a problem hiding this comment.
Hey @akshitarora921. So I think what would help a lot is for you to explain what you're doing with these keys.
- Where are they from
- What are they doing
- What we need to do
I've looked into it and it might be better next time for us to get your PR through if you outline what we need to do as a follow up to your work. A list of todos. Here's an example for todos for us:
- Go to recaptha website and generate keys for production
- Use sitekey in code (go into detail)
- Use secret key in server env (go into detail)
This would help a lot.
I see you did this which is nice. Maybe a little more detail to help us get this PR through. I’ve updated your PR description with a Self-Review Checklist and some to-dos. I also noticed that one of the checks failed. Please take a look and let me know if you need help. |
|
@LowLifeArcade updated PR description. |
Thank you @akshitarora921. Don't worry, we'll get this PR through soon. The test failure might be due to recaptcha doing its job. I don't know this for sure and will have to look into it. |
|
@LowLifeArcade yes the form does not submit until the captcha is not submitted that's why the tests are failing. |
|
|
@akshitarora921 I've been meaning to talk with you about this PR. Will you please make a test or modify the test running on the MainDonationForm component? That needs to pass in your PR before we can do anything else. |
|
@LowLifeArcade I am learning how to write tests, will update the PR as soon as possible. |
|
@akshitarora921 I think it's time we get this one through :) It's really just a matter of making it pass the test file in the repo. |

Self-Review Checklist
One variable added :
.env.exampleNEXT_PUBLIC_SITE_KEYSteps to generate Site Key:
eg: https://www.margaritahumanitarian.org/ or localhost
closes #162