fix: engine bugs, biome schema, and docs overhaul#19
Merged
marioprieta merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Engine fixes (transitionEngine.tsx): - Clear deferredSystemRestoreRef on system→explicit transition to prevent stale override - Lift explicit Appearance override in isSystemMode effect so system mode detects real OS scheme - Always return true from system mode entry block to prevent select() pill revert - Rewrite inline comments to why-only style Biome: - Update schema version from 2.4.0 to 2.4.6 to match installed CLI Docs site (17 .mdx files): - Add Fast Refresh troubleshooting section - Clarify initialTheme read-once semantics in provider.mdx - Add isTransitioning timing vs touch blocking distinction in use-theme.mdx - Add capture failure detection guidance in callbacks.mdx - Add select() rapid-tap protection docs - Add AsyncStorage validation in persistence.mdx - Add onFinishHydration explanation and state manager comparison table in zustand.mdx - Add zero-flash startup definition in system-theme.mdx - Clarify "underneath" and frame rate behavior in how-it-works.mdx - Add inline explanations in quick-start.mdx - Add useMemo explanation in react-navigation.mdx - Add nesting order diagram and headerShown note in expo-router.mdx - Add migration checklist in migration.mdx - Add "When to import" section in types.mdx - Add persistence callout for setTheme vs select in theme-picker.mdx - Add press lock note in theme-toggle.mdx Skill files (removed from repo, moved to external skills directory): - SKILL.md and references/ deleted (managed externally now)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transitionEngine.tsx: staledeferredSystemRestoreRefon system→explicit, stalelastKnownOsSchemeRefin system mode entry, and false return fromsetTheme('system')causingselect()pill revert.mdxfiles improved with clarifications on Fast Refresh,initialThemeread-once semantics,isTransitioningtiming, capture failure detection,select()press lock, AsyncStorage validation, state manager comparison, nesting diagrams, migration checklist, and moreEngine fixes
deferredSystemRestoreRefleft over from system mode overrode explicit themeAppearance.setColorSchemeoverride masks real OS value from listenersetColorScheme('unspecified')inisSystemModeeffectselect()pill reverts after system entrysetTheme('system')returnedfalsedue to prematuresystemModeRefmutationtruefrom outer system entry blockDocs improvements (highlights)
isTransitioningtiming vs touch blocking distinctiononFinishHydrationexplanation + state manager comparison table