Optimize SubtaskGraph generation#3342
Open
zhongchun wants to merge 4 commits intomars-project:masterfrom
Open
Conversation
c18d405 to
81244dc
Compare
491de95 to
8fb4545
Compare
fyrestone
reviewed
May 12, 2023
| # Note: `dtypes`, `index_value`, and `columns_value` are lazily | ||
| # initialized, so we should call property `params` to initialize | ||
| # these fields. | ||
| [o.params for o in out_chunks] |
Contributor
There was a problem hiding this comment.
It's wired, what would happen without these codes?
Contributor
Author
There was a problem hiding this comment.
There will no columns_value, index_value which are used in MainPool.
Contributor
There was a problem hiding this comment.
These field are lazily initialized, but field a or b are lazily initialized by params. Can you make a initialized by a, b initialized by b? Then we can lazily initialize them in Worker Main Pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In
gen_subtask_graph, Mars always create new out chunks even if the out chunk already exists. It costs a lot of time if there are plenty of chunks.Related issue number
Fixes #3341
I did a comparison, in which one creates new out chunks and the other does not. The test scripts are:
Cost time of
Subtaskgeneration are: 122.92s, 56.63s.Check code requirements