Skip to content

check result is defined on fetchFinished correctly#30

Open
goldensunliu wants to merge 3 commits into
martyjs:masterfrom
goldensunliu:master
Open

check result is defined on fetchFinished correctly#30
goldensunliu wants to merge 3 commits into
martyjs:masterfrom
goldensunliu:master

Conversation

@goldensunliu

Copy link
Copy Markdown

@taion

taion commented Aug 31, 2015

Copy link
Copy Markdown
Member

Hmm - I think we'd want to do == null here instead. The intended behavior here is to treat null as a "not found" response.

Otherwise, the modules directory is actually a build artifact - you only need to change src; modules will get updated on build.

@goldensunliu

Copy link
Copy Markdown
Author

@taion you mean !_.isNull we need to check the not condition here. also I added to the modules so our fork of marty can work for now. how do I call build?

@goldensunliu

Copy link
Copy Markdown
Author

@taion can we merge this?

@taion

taion commented Sep 16, 2015

Copy link
Copy Markdown
Member

Please change the check to a null check. I'll merge and re-release after.

@goldensunliu

Copy link
Copy Markdown
Author

@taion all set

@taion

taion commented Sep 16, 2015

Copy link
Copy Markdown
Member

Any insight to the failures on Travis?

@goldensunliu

Copy link
Copy Markdown
Author

nothing obvious is jumping out at me hmmm

@taion

taion commented Sep 24, 2015

Copy link
Copy Markdown
Member

I took a quick look at the test failure - this is an actual bug in your code. You're hitting the fetchFinished branch on https://github.com/goldensunliu/marty-lib/blob/777b066cf4b1c3482e7541d840e67b6c55e94e02/src/store/storeFetch.js#L89, but not actually marking the fetch as finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application.RenderToString hangs when fetch result returns the value false.

2 participants