Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on this task! Your solution is well-structured and correctly calculates the new data points for the table.
However, a small change is needed as the automated tests are failing. The "Gender" column in the table is not being populated because the code in src/scripts/main.js attempts to access person.gender. The correct property name in the data is sex.
Once you update person.gender to person.sex, the table will display correctly and the tests should pass. You're very close to finishing this!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| // Використовуємо шаблонний рядок для наповнення tr | ||
| tr.innerHTML = ` | ||
| <td>${person.name}</td> | ||
| <td>${person.gender}</td> |
There was a problem hiding this comment.
It seems there's a small typo here. The property for gender in the people objects is sex, not gender. This will cause undefined to be displayed in this cell.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this update! I am approving your solution as you've successfully addressed the feedback from the previous review. Using person.sex to populate the gender column was the correct fix. Your code is now clean, efficient, and perfectly meets all the task requirements. The table generates correctly with all the required data. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.