Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Changes are needed because the implementation has critical blockers that prevent the task from working correctly. First, line 367 references person.gender, but the data uses person.sex (e.g., 'm' or 'f'), so gender values will appear as undefined. Second, the age cell creation is incomplete — lines 377–378 start building it but never assign textContent or append it to the row. Third, the century cell is entirely missing, though it's required as the 6th cell in each row. Finally, the code never locates the dashboard table (e.g., via document.querySelector('.dashboard')) or appends the generated rows to it — so no table content appears at all. These issues violate core requirements and must be fixed before the solution functions as intended.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| const td = document.createElement('td'); | ||
| td.textContent = person.name; | ||
| tr.appendChild(td); | ||
| const tdGender = document.createElement('td'); |
There was a problem hiding this comment.
The data uses sex property (e.g., 'm'/'f'), but the code references person.gender which will be undefined. Change to person.sex.
| const tdDied = document.createElement('td'); | ||
| tdDied.textContent = person.died; | ||
| tr.appendChild(tdDied); | ||
| const tdAGE = |
There was a problem hiding this comment.
The age cell creation appears incomplete - needs to finish assigning textContent and appending to the row.
2 participants
No description provided.