chore: resolve safe SonarCloud maintainability issues (S6582, S7762)#1399
Merged
Conversation
Address low-risk, behaviour-preserving code smells: - S7762: use childNode.remove() instead of parentNode.removeChild(childNode) - S6582: prefer optional chaining over `a && a.b` guards Skipped the S7747 (unnecessary Array.from) reports: each `[...collection]` is a deliberate defensive copy because the loop body mutates the collection being iterated. Also left the CRITICAL/BLOCKER buckets untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6tAi449PHv5hbMSyhtxMk
…7735) The optional-chaining rewrite left an if/else with a negated condition. Flip to the positive `=== 'svg'` form and swap the branches so both S6582 (optional chaining) and S7735 (no negated condition) are satisfied. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6tAi449PHv5hbMSyhtxMk
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address low-risk, behaviour-preserving code smells:
a && a.bguardsSkipped the S7747 (unnecessary Array.from) reports: each
[...collection]is a deliberate defensive copy because the loop body mutates the collection
being iterated. Also left the CRITICAL/BLOCKER buckets untouched.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01B6tAi449PHv5hbMSyhtxMk