Merge latest master into v8-branch#1402
Merged
Merged
Conversation
Two MEDIUM reliability issues on new code were holding `new_reliability_rating` at C on master: - css:S8776 (_space-mixin.scss:30) "Missing scoping root" — the explicit `&` had no style-rule parent inside the @mixin. Drop it; a bare nested `.dv-dockview` compiles to the identical descendant selector (verified: compiled CSS is byte-identical) and matches the sibling selectors. - typescript:S7737 (dockviewComponent.ts removePanel/_doRemovePanel) — object literal used as a parameter default. Make `options` optional and apply the `removeEmptyGroup` default in the body; `_doRemovePanel` (single caller) now takes required options. Behaviour is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NiZ9eADKvMUzPp7JLa6cXy
fix: resolve new-code reliability issues failing the quality gate
Address low-risk, behaviour-preserving code smells: - S7762: use childNode.remove() instead of parentNode.removeChild(childNode) - S6582: prefer optional chaining over `a && a.b` guards Skipped the S7747 (unnecessary Array.from) reports: each `[...collection]` is a deliberate defensive copy because the loop body mutates the collection being iterated. Also left the CRITICAL/BLOCKER buckets untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6tAi449PHv5hbMSyhtxMk
…7735) The optional-chaining rewrite left an if/else with a negated condition. Flip to the positive `=== 'svg'` form and swap the branches so both S6582 (optional chaining) and S7735 (no negated condition) are satisfied. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6tAi449PHv5hbMSyhtxMk
chore: resolve safe SonarCloud maintainability issues (S6582, S7762)
…ster-merge-bpo9ym # Conflicts: # packages/dockview-core/src/dockview/components/panel/content.ts # packages/dockview-core/src/dockview/components/titlebar/tabGroupIndicator.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merges the latest
master(5 commits ahead ofv8-branch) intov8-branchto keep the v8 line current.Two conflicts arose, both the same pattern:
v8-branchhad already extracted inline logic into a shared method, whilemastermade small cosmetic tweaks to the old inline code. Resolved by keeping the v8 refactor and porting master's improvements into the extracted methods so nothing from master is lost:content.ts— kept thegroup.canDisplayContentOverlay(...)call; ported master'sdata && data.viewId→data?.viewIdcosmetic change intocanDisplayContentOverlayindockviewGroupPanelModel.ts.tabGroupIndicator.ts— kept theensureSvgPath(...)call, which already embodies master's improved (inverted) SVG-reuse conditional.All other master changes (
removeChild→.remove(),te?.valueoptional chaining, etc.) merged automatically.Type of change
Affected packages
dockview-coredockview-vueHow to test
This is a branch-sync merge; the incoming
mastercommits were already reviewed and merged on their own. Verify the two conflict resolutions preserve behaviour: the drop-overlay check incontent.tsstill routes throughcanDisplayContentOverlay, and the tab-group underline still reuses its SVG viaensureSvgPath. Runyarn testindockview-coreonce dependencies are installed.Checklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses🤖 Generated with Claude Code
Generated by Claude Code