refactor(core)!: rename api.moveToNext/moveToPrevious → activateNext/activatePrevious#1404
Merged
Merged
Conversation
…/activatePrevious These methods advance the active panel/group (move focus); they do not relocate a panel. The old names misread as panel-moving — especially now that keyboard docking offers a genuine "move panel" action — so rename the focus-navigation path to `activateNext`/`activatePrevious`, aligning with `activeGroup`/`activePanel`. - DockviewApi: add `activateNext`/`activatePrevious`; keep `moveToNext`/ `moveToPrevious` as @deprecated aliases (removal planned for a future major). - DockviewComponent + BaseGrid: rename the internal methods. - The group-model `moveToNext`/`moveToPrevious` (active-panel cycling within a group, used by keyboard tab switching) are a different concept and unchanged. - Docs: focus-navigation, keyboard, features + llms; regenerated api.output.json. Also tidied awkward "free <noun>" wording flagged in review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the public focus-navigation API on
DockviewApi:activateNext(options?)/activatePrevious(options?)moveToNext/moveToPreviousstill work (delegate to the new methods), with@deprecatedJSDoc and removal planned for a future major.Why
These methods advance the active panel/group (move focus) — they do not relocate a panel. The old names misread as panel-moving, which is now actively confusing because keyboard docking offers a real "move panel" action. The new names align with the existing
activeGroup/activePanelvocabulary.Scope
DockviewApi,DockviewComponent(interface + impl), andBaseGridrenamed.moveToNext/moveToPrevious(active-panel cycling within a group, powering keyboard tab-switching) — a different concept, left as-is.focus-navigation.mdx(+ "Renamed in v8" note),keyboard.mdx,features.mdx,llms-full.txt; regeneratedapi.output.json. Also tidied some awkward "free <noun>" wording.Verification
dockview-coresuite: 1128/1128 passing (incl. new delegation + deprecated-alias guard tests).🤖 Generated with Claude Code