Skip to content

Release chunk entries while iterating blobs in ArchiveSelector#24220

Merged
sgiehl merged 1 commit into5.x-devfrom
split/archive-selector-unset-blobs
Mar 15, 2026
Merged

Release chunk entries while iterating blobs in ArchiveSelector#24220
sgiehl merged 1 commit into5.x-devfrom
split/archive-selector-unset-blobs

Conversation

@sgiehl
Copy link
Copy Markdown
Member

@sgiehl sgiehl commented Mar 13, 2026

Description

When iterating chunked blob records, the entire $blobs array remains populated until loop end, which may increase peak memory use for large chunks.

refs #24191

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@sgiehl sgiehl added this to the 5.9.0 milestone Mar 13, 2026
@sgiehl sgiehl added c: Performance For when we could improve the performance / speed of Matomo. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 13, 2026
@sgiehl sgiehl marked this pull request as ready for review March 13, 2026 16:33
@sgiehl sgiehl requested a review from a team March 13, 2026 16:33
@sgiehl sgiehl merged commit c1fd5bf into 5.x-dev Mar 15, 2026
51 of 53 checks passed
@sgiehl sgiehl deleted the split/archive-selector-unset-blobs branch March 15, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Performance For when we could improve the performance / speed of Matomo. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Development

Successfully merging this pull request may close these issues.

2 participants