Skip to content

CoreUpdater: prevent token creation/disclosure via oneClickResults#24240

Draft
sgiehl wants to merge 1 commit into5.x-devfrom
dev-19893
Draft

CoreUpdater: prevent token creation/disclosure via oneClickResults#24240
sgiehl wants to merge 1 commit into5.x-devfrom
dev-19893

Conversation

@sgiehl
Copy link
Copy Markdown
Member

@sgiehl sgiehl commented Mar 17, 2026

Summary

This PR refines the CoreUpdater one-click update flow by centralizing update_details_token lifecycle handling in oneClickUpdate()
and keeping oneClickResults() focused on rendering.

What changed

  • In plugins/CoreUpdater/Controller.php:
  • oneClickUpdate() now rotates update_details_token at update start.
  • oneClickResults() now reads existing token state and does not persist token changes.
  • oneClickResults() includes updateDetailsToken in runUpdaterUrl only in superuser context.
  • Added helper methods for explicit token refresh/read behavior:
  • refreshUpdateDetailsToken()
  • getUpdateDetailsToken()

Behavior impact

  • Token management is now aligned with update initiation.
  • Result page rendering remains intact and continues to provide a valid continuation URL when applicable.
  • Existing token cleanup behavior after update completion remains unchanged.

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@sgiehl sgiehl added this to the 5.9.0 milestone Mar 17, 2026
@sgiehl sgiehl force-pushed the dev-19893 branch 3 times, most recently from 3620689 to 5748421 Compare March 18, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant