Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| support_l2_legacy_shared_bridge_test = false | ||
|
|
||
| old_protocol_version = "0x1d00000001" | ||
| old_protocol_version = 1c00000001 |
There was a problem hiding this comment.
Fix malformed old_protocol_version in testnet config
The testnet TOML now sets old_protocol_version = 1c00000001 without a 0x prefix or quotes, which is not valid TOML and cannot be parsed by stdToml.readUint("$.old_protocol_version") in DefaultEcosystemUpgrade.initializeConfig, so running the v30 upgrade for testnet will fail before any calls are generated.
Useful? React with 👍 / 👎.
|
|
||
| governance_security_council_address = "0x25Ab0397DA109A50C8921A1d4a034e0973602469" | ||
| latest_protocol_version = "0x1e00000000" | ||
| latest_protocol_version = 0x1d00000001 |
There was a problem hiding this comment.
Testnet latest_protocol_version still targets v29
latest_protocol_version for testnet remains 0x1d00000001 (v29.1), while other envs use 0x1e... for the v30 upgrade; with this value the upgrade script will consider the new protocol already installed and fail the ctmProtocolVersion != getNewProtocolVersion() guard in DefaultEcosystemUpgrade.setAddressesBasedOnBridgehub, blocking the testnet upgrade.
Useful? React with 👍 / 👎.
What ❔
Scripts and generated calldata for the v30 zksync os blobs upgrade.
Note, that for mainnet there are no deployed chains, which required slight modification of the upgrade. I decided to still provide formal "upgrade calldata" for consistency sake, but it does not have the deleted facets and so it is never expected to be run.
Why ❔
Checklist