Open
Conversation
Owner
|
@NickBorgers Hey! Thanks for this. I'll set aside some time this weekend to review and get it merged. Appreciate it. 🥇 |
Author
Bumping this. I don't understand what happened with the Travis CI job; I'm not sure my changes caused it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR would resolve #4 by adding a new method
func (c *Client) CompromisedCount(value string) (bool, int64, error).I turned
func (c *Client) Compromised(value string) (bool, error)into a wrapper that simply doesn't return theintcount. This maintains the API contract while minimizing extra lines of code.I also containerized testing by adding a
MakefileandDockerfile, but those have no effect on functionality. I've been runningmake testrepeatedly to validate changes;make buildonce to build the base image.