Add code to support %DOMAIN% tag replacer#1371
Add code to support %DOMAIN% tag replacer#1371nrathaus wants to merge 11 commits intomaurosoria:masterfrom
Conversation
|
Hi! Glad to meet you @nrathaus ! How you doing? I like it but I wonder, for example if type www.example.com:
For example, given the case "%DOMAIN%.zip":
|
|
@maurosoria I added the iterator so that it will go through the Let me know if this is what you were expecting |
|
Hi again! I see you got me but there are 3 issues with your commit:
Thanks for your quick response. If you feel I am too demanding please tell me. I Like your patch (I also like other ones like %YEAR%!!!)! |
|
I did a one tag replacer because EXT had a similar design, to support multiple tags - we would need to rewrite the whole function used - I am ok with doing that |
|
Regarding I added additional code, didn't get a chance to test it yet - will try to do it later |
|
Another problem I found in this PR: Assuming you run on 2 targets: |
|
Not sure how to do that |
Description
What will it do?
If this PR will fix an issue, please address it:
#1313
if it finds a
%DOMAIN%tag inside the dictionary, it will replace it with thehostnamefield of the URL - if multiple URLs are provided it will replace it multiple times