Guard wildcard similarity for large bodies - #1572
Merged
Merged
Conversation
maurosoria
force-pushed
the
scanner-wildcard-similarity-guard
branch
from
June 8, 2026 05:26
59b5f76 to
054134a
Compare
maurosoria
force-pushed
the
scanner-wildcard-similarity-guard
branch
from
June 8, 2026 05:31
054134a to
c739138
Compare
maurosoria
marked this pull request as ready for review
June 8, 2026 05:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content_similarityis called while medium-size bodies still use the fallback.Why
The ambiguous wildcard fallback is useful for dynamic soft-404 pages, but full body similarity can become unnecessarily expensive on very large responses. For large bodies, this PR keeps the heuristic conservative and avoids the costly comparison without disabling the fallback for ordinary and moderately large HTML error pages.
Validation
python -m unittest tests.core.test_scannerpython -m unittest tests.core.test_scanner tests.core.test_wordlist_backend tests.core.test_dictionary_templatespython dirsearch.py -u https://example.com -w tests/static/wordlist.txt -qgit diff --check