Skip to content

Conversation

@danieleades
Copy link
Contributor

No description provided.

@danieleades
Copy link
Contributor Author

one target is failing since the cargo-cross images are wildly out of date. hasn't been a release for a couple of years

@danieleades
Copy link
Contributor Author

you can track progress towards the next cross release here - https://github.com/cross-rs/cross/milestone/2

@joaoantoniocardoso
Copy link
Collaborator

joaoantoniocardoso commented Jan 7, 2026

If I understood it correctly, the proposal is removing a feature to make the code compatible with an outdated building tool. Questions: (1) could this feature be useful for anyone else? (2) Why not disable the feature?

Another option is to custom-make an image compatible with cross like these bullseye with gstreamer images that we use to cross-build Mavlink Camera Manager.

@danieleades
Copy link
Contributor Author

If I understood it correctly, the proposal is removing a feature to make the code compatible with an outdated building tool. Questions: (1) could this feature be useful for anyone else? (2) Why not disable the feature?

Another option is to custom-make an image compatible with cross like these bullseye with gstreamer images that we use to cross-build Mavlink Camera Manager.

not exactly. It's removing a workaround which was needed for older versions of rust which is no longer needed. Except it is needed in cross environments because the images are so old.

There is no impact to users of the library from removing this workaround, but it simplifies the codebase and improves maintainability.

increasing the complexity of the CI in order to decrease the simplicity of the code doesn't seem particularly useful. I recommend waiting until cross makes their next release before merging this.

@joaoantoniocardoso
Copy link
Collaborator

Fair, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants