-
Notifications
You must be signed in to change notification settings - Fork 99
Bump MAVLink version #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump MAVLink version #454
Conversation
|
There seem to be new dialects added with this change. They should be properly integrated (feature gate defined in cargo.toml and doc for there existence in the lib.rs top comment). |
Good catch. I just created this issue regarding to same problem. |
|
I have added feature gates and documentation for the new dialects. However, is invalid, since |
|
|
| self.contains(Self::MAV_BOOL_TRUE) | ||
| *self == Self::MAV_BOOL_TRUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not right as self implements bitflags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need some input on how to solve this.
The problem is that self does not implement bitflags if the dialect defines MAV_BOOL but does not use it in any messages (e.g. the standard dialect).
I think the best solution would be to default to either u8 or i8 if the type of MAV_BOOL can't be deduced from how it is used in the dialect. Then MAV_BOOL would always implement bitflags and self.contains(Self::MAV_BOOL_TRUE) would always be valid.
The only way I could see that this could cause problems is if a dialect that currently defines but not use MAV_BOOL starts using MAV_BOOL in a way that does not agree with the default.
However, I'm not sure if the current solution (not implementing bitflags at all) would be any better in that case.
I'm also open to other suggestions.
Bump the MAVLink version to the latest as of 2026-01-16.
Also adds support for the "superseded" tag , which is required for the new message definitions.