Skip to content

Mark SetBrightness D-Bus calls as no-reply to prevent a reply leak that exhausts the user's bus quota #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-baz merged 2 commits into from
Jun 10, 2026
Merged

Mark SetBrightness D-Bus calls as no-reply to prevent a reply leak that exhausts the user's bus quota #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6a2d88
Mark SetBrightness D-Bus calls as no-reply to prevent reply leak
d3vv3 Jun 9, 2026
b954e0d
Remove comments
max-baz Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/brightness/backlight.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,14 @@ impl Backlight {
if self.has_write_permission {
write(&mut self.file, value as f64).await?;
} else if let Some(dbus) = &self.dbus {
let mut message = dbus
.message
.duplicate()
.map_err(Error::msg)?
.append1(value as u32);
message.set_no_reply(true);
dbus.connection
.send(
dbus.message
.duplicate()
.map_err(Error::msg)?
.append1(value as u32),
)
.send(message)
.map_err(|_| anyhow!("Unable to send brightness change message via dbus"))?;
self.pending_dbus_write = true;
} else {
Expand Down
Loading