v2.1.0 — AWS API alignment, Docker dev env, contributor PRs#130
Merged
Conversation
7d4be08 to
a97787f
Compare
There was a problem hiding this comment.
Pull request overview
Maintenance release to align the CloudWatch handler with post-2022 AWS CloudWatch Logs API behavior (sequence token deprecation, init flow changes, larger event splitting), while adding a Docker-based dev/CI environment and updating docs/changelog accordingly.
Changes:
- Update
CloudWatchhandler: remove sequence token + self-throttle, raise event chunk limit, switch init to idempotentcreate*withResourceAlreadyExistsExceptionhandling, and addflush()/reset()flushing. - Rewrite unit tests to match the new initialization flow and new flush/reset behavior.
- Add Docker/Compose/Makefile-based dev+CI setup and update documentation/changelog to reflect the release.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/Handler/CloudWatch.php |
AWS API alignment (no sequence token, no self-throttle), idempotent init, new flush() + reset() behavior. |
tests/Handler/CloudWatchTest.php |
Updates tests to cover new init strategy and flush/reset behavior. |
README.md |
Adds IAM Task Role guidance and updates IAM permissions section to remove reliance on Describe*. |
CHANGELOG.md |
Introduces changelog entries for v2.1.0 release contents. |
docker/Dockerfile |
Adds a PHP CLI image for containerized dev/CI (Composer + pcov). |
compose.yaml |
Defines PHP version matrix services for local/dev CI parity. |
Makefile |
Adds standardized Docker-driven commands for build/lint/test/matrix/coverage. |
.github/workflows/php.yml |
Replaces setup-php based CI with container-based CI driven by make. |
.gitattributes |
Excludes dev/CI files from Composer dist exports. |
.dockerignore |
Shrinks Docker build context. |
.gitignore |
Ignores generated build/ artifacts. |
composer.json |
Reformats JSON and updates package metadata. |
Comments suppressed due to low confidence (2)
Makefile:35
- The
analysetarget callsvendor/bin/phpstan, butcomposer.jsondoesn’t currently require phpstan inrequire-dev. Either add the dependency (e.g.,phpstan/phpstan) or adjust/remove this target somake analyseworks aftermake install.
analyse:
$(DC) vendor/bin/phpstan analyse --level=8 src/
Makefile:26
test-coveragewrites tobuild/logs/clover.xml, but the Makefile never createsbuild/logs. On a clean checkout this typically causes PHPUnit to fail to open the file and the workflow’s upload step will error. Add a step to create the directory before running PHPUnit (or write to an existing path).
test-coverage:
$(DC) vendor/bin/phpunit --coverage-text --coverage-clover build/logs/clover.xml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e813321 to
1218f51
Compare
d717dbb to
e6feaf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.1.0 maintenance release. No breaking changes.
flush()+ overridereset()for long-lived workers ([BUG] Logs are not sent in Laravel queues #95)Closes #95, #101, #103, #111, #114. Adopts #102, #115.