Skip to content

Add 214.61.39.9 as an enterprise test network#170

Merged
dhogan8 merged 1 commit intomainfrom
dallas/add-new-NJ-IP
Aug 7, 2025
Merged

Add 214.61.39.9 as an enterprise test network#170
dhogan8 merged 1 commit intomainfrom
dallas/add-new-NJ-IP

Conversation

@dhogan8
Copy link
Contributor

@dhogan8 dhogan8 commented Jun 17, 2025

No description provided.

Copy link

@oalders-mm oalders-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it matters much, but I think you only really need to include:

  • test-data/GeoIP2-Precision-Enterprise-Test.mmdb
  • test-data/GeoIP2-Precision-Enterprise-Shield-Test.mmdb

The other database changes are likely just datestamps in the metadata.

@dhogan8
Copy link
Contributor Author

dhogan8 commented Jun 17, 2025

Not that it matters much, but I think you only really need to include:

  • test-data/GeoIP2-Precision-Enterprise-Test.mmdb
  • test-data/GeoIP2-Precision-Enterprise-Shield-Test.mmdb

The other database changes are likely just datestamps in the metadata.

Gotcha, thanks! I mostly just copied the step by step from the Engineering docs and all the DBs got updated.

@oalders-mm
Copy link

Right. They will all get updated. What you're seeing here is the result of git add .

@horgh
Copy link
Contributor

horgh commented Aug 6, 2025

@dhogan8 should this be merged?

@dhogan8
Copy link
Contributor Author

dhogan8 commented Aug 7, 2025

@horgh Ah yes. I must have forgotten to merge this. Thank you for flagging this.

@dhogan8 dhogan8 force-pushed the dallas/add-new-NJ-IP branch from 4621d33 to 9156290 Compare August 7, 2025 12:40
@dhogan8
Copy link
Contributor Author

dhogan8 commented Aug 7, 2025

@oalders-mm Could you re-review this please? I forgot to merge it the first time around and then had to deal with merge conflicts.

@dhogan8 dhogan8 requested a review from oalders-mm August 7, 2025 12:42
Copy link

@oalders-mm oalders-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhogan8 dhogan8 merged commit 6763a49 into main Aug 7, 2025
10 checks passed
@dhogan8 dhogan8 deleted the dallas/add-new-NJ-IP branch August 7, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants