Open
Conversation
Author
|
(sorry for the reformatting btw, VSCode config doing stupid stuff. I can revert it if wanted) |
Owner
|
Hey @aumetra thanks for the PR, and I'm interested in getting this into |
mcginty
requested changes
Sep 22, 2025
nazar-pc
reviewed
Dec 4, 2025
Comment on lines
+596
to
+606
| fn name(&self) -> &'static str { | ||
| "BLAKE3" | ||
| } | ||
|
|
||
| fn block_len(&self) -> usize { | ||
| blake3::BLOCK_LEN | ||
| } | ||
|
|
||
| fn hash_len(&self) -> usize { | ||
| blake3::OUT_LEN | ||
| } |
There was a problem hiding this comment.
Would be nice to change these to trait constants once breaking changes are made in the library:
Suggested change
| fn name(&self) -> &'static str { | |
| "BLAKE3" | |
| } | |
| fn block_len(&self) -> usize { | |
| blake3::BLOCK_LEN | |
| } | |
| fn hash_len(&self) -> usize { | |
| blake3::OUT_LEN | |
| } | |
| const NAME: &'static str = "BLAKE3"; | |
| const BLOCK_LEN: usize = blake3::BLOCK_LEN; | |
| const HASH_LEN: usize = blake3::OUT_LEN; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
This PR adds support for using the BLAKE3 hash function as part of a Noise connection.
Unfortunately I'm not sure if there are any test vectors for it available.
But yeah, this adds a new hash state enum variant for BLAKE3 and adds support for it to the default provider.