Fix aliasAs generating wrong type for the alias variable#136
Open
dillonkearns wants to merge 1 commit intomdgriffith:mainfrom
Open
Fix aliasAs generating wrong type for the alias variable#136dillonkearns wants to merge 1 commit intomdgriffith:mainfrom
dillonkearns wants to merge 1 commit intomdgriffith:mainfrom
Conversation
When using Elm.Arg.aliasAs on a record pattern, the alias variable
was given a fresh type variable instead of inheriting the underlying
pattern's type.
Before:
Arg.record ... |> Arg.field "name" |> Arg.aliasAs "person"
generated: { name : name, age : age } -> ( name, person )
(person is wrong - should be the record type)
After:
generated: { name : name, age : age }
-> ( name, { name : name, age : age } )
Root cause: aliasAs was calling `val` which creates a fresh
`GenericType` for the alias name. The fix uses the inner pattern's
annotation (the actual record/tuple/etc type) for the alias value.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
Elm.Arg.aliasAson a record pattern, the alias variable was incorrectly using a fresh type variable instead of inheriting the underlying pattern's type.For example, here's what this snippet generates:
Before:
(
personis wrong - should be the record type)After:
Root cause: aliasAs was calling
valwhich creates a freshGenericTypefor the alias name. The fix uses the inner pattern's annotation (the actual record/tuple/etc type) for the alias value.