fix: avoid private telemetry thread state - #180
Merged
Conversation
b3by
requested changes
May 25, 2026
Collaborator
There was a problem hiding this comment.
I would completely skip testing for this fix, especially considering the approach of mocking the entire Thread class. Could you please remove this file from the PR?
Mirochill
force-pushed
the
fix-179-telemetry-stop-python313
branch
from
May 25, 2026 08:26
992bd3b to
543e90a
Compare
Contributor
Author
|
Thanks, removed Validation:
Not run locally: test suite. |
Collaborator
|
Super, thank you! |
b3by
marked this pull request as ready for review
May 26, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #179 by avoiding
threading.Thread._is_stoppedinTelemetryManager.stop(). Python 3.13+ no longer keeps this private implementation detail stable, so stopping telemetry can crash while checking the telemetry thread.PR type
Select all the labels that apply to this PR.
Key modifications and changes
_is_stoppedcheck with the publicThread.is_alive()API.Affected components
Juturna core library:
TelemetryManager.Additional context
Validation:
git diff --check HEAD~1..HEADrg -n _is_stopped|is_alive|test_telemetry_stop_uses_public_thread_api juturna testsNot run locally.