Skip to content

Bump meilisearch to v1.40#2155

Merged
Strift merged 2 commits intomainfrom
chore/bump-meilisearch-to-v1.40
Mar 24, 2026
Merged

Bump meilisearch to v1.40#2155
Strift merged 2 commits intomainfrom
chore/bump-meilisearch-to-v1.40

Conversation

@Strift
Copy link
Collaborator

@Strift Strift commented Mar 24, 2026

Pull Request

What does this PR do?

Bump Meilisearch in CI + docker compose to v1.40

The automation failed, so I fixed it too

PR checklist

Please check if your PR fulfills the following requirements:

  • Did you use any AI tool while implementing this PR (code, tests, docs, etc.)? If yes, disclose it in the PR description and describe what it was used for. AI usage is allowed when it is disclosed.
  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores
    • Upgraded Meilisearch service to version 1.40 in test and development environments (was 1.37).
    • Updated supporting automation to correctly apply the new Meilisearch tag during CI and local setup.

@Strift Strift added the maintenance Issue about maintenance (CI, tests, refacto...) label Mar 24, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

Bumped Meilisearch Enterprise Docker image tag from v1.37 to v1.40 in CI workflow and Docker Compose; updated the repository script that performs the in-place sed replacement to use # delimiters and correct escaped capture usage.

Changes

Cohort / File(s) Summary
Meilisearch image bump
.github/workflows/tests.yml, docker-compose.yml
Replaced Meilisearch Docker image tag getmeili/meilisearch-enterprise:v1.37getmeili/meilisearch-enterprise:v1.40 in CI and compose configurations.
Bump script sed update
.github/scripts/bump-meilisearch-version.sh
Changed sed delimiter from `

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny hop, a tidy swap,
New tag in place, I never stop.
v1.40 shines, the tests set free,
I nibble bytes with joyful glee. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the primary change: upgrading Meilisearch from v1.37 to v1.40 across all configuration files and scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-meilisearch-to-v1.40

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Strift Strift requested review from a team and flevi29 March 24, 2026 09:49
@Strift Strift enabled auto-merge March 24, 2026 09:49
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.95%. Comparing base (d2d31c4) to head (eef6df5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2155   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files          15       15           
  Lines         635      635           
  Branches      105      104    -1     
=======================================
  Hits          622      622           
  Misses         12       12           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docker-compose.yml`:
- Line 17: Replace the non-existent image tag
getmeili/meilisearch-enterprise:v1.40 with the valid release tag
getmeili/meilisearch-enterprise:v1.39.0; locate the line containing the image
string "getmeili/meilisearch-enterprise:v1.40" and update only the tag portion
to ":v1.39.0" so Docker Compose pulls the correct Meilisearch Enterprise
version.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10f2360a-efc2-4278-8b68-5c2c77399b3c

📥 Commits

Reviewing files that changed from the base of the PR and between d2d31c4 and 4f8da8b.

📒 Files selected for processing (2)
  • .github/workflows/tests.yml
  • docker-compose.yml

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/scripts/bump-meilisearch-version.sh (1)

47-47: Consider using # delimiter here for consistency.

This sed command still uses | as the delimiter. While it works correctly (the pattern has no alternation), updating it to use # would maintain consistency with lines 78 and 81, making the script easier to maintain.

♻️ Suggested change
-CURRENT_TAG="$(sed -nE "s|.*${MEILISEARCH_DOCKER_IMAGE}:(v[0-9]+\.[0-9]+(\.[0-9]+)?)|\1|p" "${DOCKER_COMPOSE_FILE}" | head -n 1 || true)"
+CURRENT_TAG="$(sed -nE "s#.*${MEILISEARCH_DOCKER_IMAGE}:(v[0-9]+\.[0-9]+(\.[0-9]+)?)#\\1#p" "${DOCKER_COMPOSE_FILE}" | head -n 1 || true)"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/scripts/bump-meilisearch-version.sh at line 47, The sed invocation
that sets CURRENT_TAG uses the pipe delimiter; update the sed expression that
references MEILISEARCH_DOCKER_IMAGE and DOCKER_COMPOSE_FILE so it uses the hash
(#) delimiter instead of | (i.e., change the sed delimiter around the s///
pattern used to extract the tag for CURRENT_TAG) to match the style used
elsewhere and keep consistent escaping and grouping for the capture (vX.Y(.Z)?).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/scripts/bump-meilisearch-version.sh:
- Line 47: The sed invocation that sets CURRENT_TAG uses the pipe delimiter;
update the sed expression that references MEILISEARCH_DOCKER_IMAGE and
DOCKER_COMPOSE_FILE so it uses the hash (#) delimiter instead of | (i.e., change
the sed delimiter around the s/// pattern used to extract the tag for
CURRENT_TAG) to match the style used elsewhere and keep consistent escaping and
grouping for the capture (vX.Y(.Z)?).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73446fba-dab7-4f30-a3ca-f4559c63d8aa

📥 Commits

Reviewing files that changed from the base of the PR and between 4f8da8b and eef6df5.

📒 Files selected for processing (1)
  • .github/scripts/bump-meilisearch-version.sh

Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel like #2035 is a better option, @curquiza what do you think?

@Strift Strift added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit 4621dd3 Mar 24, 2026
7 checks passed
@Strift Strift deleted the chore/bump-meilisearch-to-v1.40 branch March 24, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Issue about maintenance (CI, tests, refacto...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants