Open
Conversation
varsill
approved these changes
Apr 17, 2026
| defp prepend_llms_links(_) do | ||
| path = "doc/llms.txt" | ||
|
|
||
| if File.exists?(path) do |
There was a problem hiding this comment.
I assume that with new versions of ex_doc, llms.txt should always exist, is that right?
Let's add a warning when it doesn't exist since it indicates that something is misconfigured.
| if File.exists?(path) do | ||
| existing = File.read!(path) | ||
|
|
||
| header = "- [Membrane Core](https://hexdocs.pm/membrane_core/llms.txt)\n\n" |
There was a problem hiding this comment.
Let's make sure that this line is appended only to "plugins" which depend on core (and not, e.g. to bundlex etc.)
There was a problem hiding this comment.
And a side question - shouldn't we "version" the membrane_core's llms.txt?
We could e.g. get membrane_core locked version using Mix.Dep.Lock.read() and use it in this link.
It's probably not that important, but I wanted to put it into discussion.
varsill
reviewed
Apr 17, 2026
varsill
left a comment
varsill
left a comment
There was a problem hiding this comment.
Please update version in README as well
varsill
requested changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
formatters: ["html"]fromdocs/0— restores ex_doc default (generates HTML + Markdown)ex_docto latest, updatemix.lockmix docsalias that prepends Membrane Core links todoc/llms.txt