-
Notifications
You must be signed in to change notification settings - Fork 78
[WC-3361] FileUploader: enhance limits and feedback #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yordan-st
wants to merge
13
commits into
main
Choose a base branch
from
fix/WC-3361_fileuploader-limit-feedback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c9df7e3
chore: lint fix
yordan-st 9c8a49f
fix: show message when upload limit reached
yordan-st fc59393
chore: update changelog
yordan-st 151b0eb
fix: allow maxFilesPerUpload to be optional and handle undefined value
yordan-st d61f649
chore: update changelog to reflect changes in file limit reached mess…
yordan-st 3eb9b23
feat: add maxFilesPerBatch property and related messages for upload l…
yordan-st fba1c6f
fix: improve upload limit feedback and retry behavior
yordan-st e453a08
refactor: reorder imports for better organization in FileUploaderStor…
yordan-st 8a8fd7a
fix: remove redundant error handling for too many files in processDro…
yordan-st c150995
feat: replace error/retry throttling with upload queue
yordan-st 4eaaaa3
refactor: enhance file upload limit feedback and error handling
yordan-st 7b0c130
feat: add retry button for limit-rejected files
yordan-st 068ffaa
refactor: encapsulate translations, consolidate reactions
yordan-st File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/pluggableWidgets/file-uploader-web/src/FileUploader.editorPreview.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
packages/pluggableWidgets/file-uploader-web/src/assets/retry-icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion
2
packages/pluggableWidgets/file-uploader-web/src/components/ActionButton.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 3 additions & 12 deletions
15
packages/pluggableWidgets/file-uploader-web/src/components/Dropzone.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
packages/pluggableWidgets/file-uploader-web/src/components/RetryButton.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { observer } from "mobx-react-lite"; | ||
| import { MouseEvent, ReactElement, useCallback } from "react"; | ||
| import { FileStore } from "../stores/FileStore"; | ||
| import { useTranslationsStore } from "../utils/useTranslationsStore"; | ||
|
|
||
| interface RetryButtonProps { | ||
| store: FileStore; | ||
| } | ||
|
|
||
| export const RetryButton = observer(function RetryButton({ store }: RetryButtonProps): ReactElement { | ||
| const translations = useTranslationsStore(); | ||
|
|
||
| const onClick = useCallback( | ||
| (e: MouseEvent<HTMLButtonElement>) => { | ||
| e.stopPropagation(); | ||
| store.retry(); | ||
| }, | ||
| [store] | ||
| ); | ||
|
|
||
| return ( | ||
| <button | ||
| className="retry-button" | ||
| disabled={!store.canRetry} | ||
| onClick={onClick} | ||
| title={translations.get("retryButtonTextMessage")} | ||
| > | ||
| <span className="retry-icon" aria-hidden /> | ||
| </button> | ||
| ); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.