ci: specify master branch for meshery checkout in e2etests#195
ci: specify master branch for meshery checkout in e2etests#1952004Pruthvi wants to merge 4 commits intomeshery-extensions:masterfrom
Conversation
Signed-off-by: pruthvi@2004 <pruthviraj462004@gmail.com@2004Pruthvi.noreply.github.com>
|
Hi @leecalcote / @theBeginner86, I've just submitted a PR to fix this. I've updated the e2etests.yaml to explicitly checkout the master branch, which should resolve the detached HEAD failure during doc publishing. Looking forward to your feedback! |
2004Pruthvi
force-pushed
the
fix/ci-checkout-branch
branch
from
580ebe6 to
a38d680
Compare
Signed-off-by: pruthvi@2004 <165915900+2004Pruthvi@users.noreply.github.com>
2004Pruthvi
force-pushed
the
fix/ci-checkout-branch
branch
from
a38d680 to
e8c8dee
Compare
|
Running build checks... |
There was a problem hiding this comment.
Pull request overview
Updates CI configuration to ensure the E2E workflow checks out the meshery/meshery repo on a named branch (avoiding detached HEAD) and modernizes parts of the repo’s golangci-lint configuration.
Changes:
- Pin
meshery/mesherycheckout ine2etestsworkflow toref: masterto avoid detached HEAD. - Update
.golangci.ymlto newer linter configuration schema (depguard rules, mnd rename, gosec excludes, gci sections). - Remove some prior golangci-lint configuration (skip-dirs, service block, comments).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .golangci.yml | Migrates/adjusts golangci-lint config and removes prior exclusions/version pin block. |
| .github/workflows/e2etests.yaml | Ensures the external repo checkout targets master explicitly. |
Comments suppressed due to low confidence (1)
.golangci.yml:1
- The config adds
linters-settings.mndand anexclude-rulesentry formnd, butmndis not enabled (withdisable-all: true, it won’t run). If the intent is to actually enforce magic-number checks, addmndunderlinters.enable; otherwise, remove themndsettings/exclude rule to avoid confusing dead configuration.
linters-settings:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| repository: meshery/meshery | ||
| token: ${{ secrets.GH_ACCESS_TOKEN }} | ||
| ref: master |
| - internal/cache | ||
| - internal/renameio | ||
| - internal/robustio | ||
| timeout: 5m |
| rules: | ||
| main: | ||
| files: | ||
| - $all | ||
| deny: | ||
| - pkg: "github.com/sirupsen/logrus" | ||
| desc: "logging is allowed only by logutils.Log" |
| mnd: | ||
| checks: | ||
| - argument | ||
| - case | ||
| - condition | ||
| - return |
Signed-off-by: pruthvi@2004 <165915900+2004Pruthvi@users.noreply.github.com>
lekaf974
left a comment
lekaf974
left a comment
There was a problem hiding this comment.
if you modify this use latest version please
.github/workflows/e2etests.yaml
Outdated
| echo "version=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV | ||
| fi | ||
| - uses: actions/checkout@master | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v6 |
.github/workflows/e2etests.yaml
Outdated
| ref: master | ||
| - name: DownloadJSON | ||
| uses: actions/download-artifact@v2 | ||
| uses: actions/download-artifact@v4 |
There was a problem hiding this comment.
| uses: actions/download-artifact@v4 | |
| uses: actions/download-artifact@v8 |
There was a problem hiding this comment.
hank you for the catch, @lekaf974! I've updated the workflow to use checkout@v6 and download-artifact@v8 as suggested. Ready for another look.
…fact@v8) Signed-off-by: pruthvi@2004 <165915900+2004Pruthvi@users.noreply.github.com>
|
Also, could someone please approve the workflows so CI checks can run? |
|
Hi @lekaf974, I’ve addressed all the requested changes and updated the workflow versions (checkout@v6, download-artifact@v8). Could you please take another look when you have time? Thanks! |
Description
This PR addresses the issue where the
e2etestsworkflow was checking out themeshery/mesheryrepository in a "detached HEAD" state. By explicitly specifyingref: master, we ensure that the subsequent steps (like publishing compatibility docs) have the correct branch context to perform a push.Changes
actions/checkoutin.github/workflows/e2etests.yamlto includeref: master.actions/checkoutversion tov4for stability.Fixes
Fixes #190