Conversation
Contributor
⚡ Try this PR in the Web Flasher
Warning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (27)
Build artifacts expire on 2026-08-06. Updated for |
github-actions
Bot
added
needs-review
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a HUB75 RGB LED matrix display driver, wires it into Screen selection logic, and introduces a new ESP32-S3 ChangesHUB75 Display Driver
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/graphics/HUB75Display.cpp (1)
44-46: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueTrim the multi-line comment.
The single-buffer rationale spans three lines. As per coding guidelines, keep code comments to "one or two lines maximum."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/graphics/HUB75Display.cpp` around lines 44 - 46, Trim the explanatory comment in HUB75Display so it fits the one- or two-line guideline by shortening the rationale around cfg.double_buff; keep only the essential single-buffer note and remove the extra wrapped lines while preserving the meaning in the HUB75Display setup code.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/graphics/HUB75Display.cpp`:
- Around line 48-56: `HUB75Display::connect()` leaves `matrix` allocated when
`MatrixPanel_I2S_DMA::begin()` fails, so subsequent `display()` and
`sendCommand()` calls can still use a half-initialized panel and the allocation
leaks. Update the failure path in `connect()` to clean up the `matrix` member by
deleting the failed `MatrixPanel_I2S_DMA` instance and resetting `matrix` to
null before returning false, keeping the existing success path unchanged.
---
Nitpick comments:
In `@src/graphics/HUB75Display.cpp`:
- Around line 44-46: Trim the explanatory comment in HUB75Display so it fits the
one- or two-line guideline by shortening the rationale around cfg.double_buff;
keep only the essential single-buffer note and remove the extra wrapped lines
while preserving the meaning in the HUB75Display setup code.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d7b924b4-9f28-4403-b80d-6440b48122ad
📒 Files selected for processing (5)
src/graphics/HUB75Display.cppsrc/graphics/HUB75Display.hsrc/graphics/Screen.cppvariants/esp32s3/visualizer-hub75/platformio.inivariants/esp32s3/visualizer-hub75/variant.h
Contributor
Firmware Size Report23 targets | vs
Show 18 more target(s)
Size budgets
Budgets live in Updated for 4a84614 |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilizing HUB75 display with DMA refresh
Summary by CodeRabbit
New Features
Bug Fixes