Make more stuff translatable#601
Draft
reosarevok wants to merge 19 commits into
Draft
Conversation
It looks like this was intended to be used for a tier upgrade process, but we currently just do that by letting the user mail us. is_upgrade does not seem to be set anywhere in the codebase.
Otherwise we are promising more than we should.
As worded this suggests we would block access to all our APIs, but most of them are public. This seems to be meant specifically for the replication API only.
This seems to not change the meaning at all, but require double the translator effort.
We have received several checks every year, including some for thousands of dollars - we should not say we don't accept them entirely, but we should discourage their use. For what it's worth, we pay $10 or more in fees every time we make someone go to the bank and cash a check for us.
We already do so for "Commercial".
Without that the order wouldn't make sense in many languages.
This makes it a lot more clear for translation.
This is otherwise almost entirely untranslateable.
This makes it a lot more clear for translation.
reosarevok
requested review from
MonkeyDo and
amCap1712
and removed request for
amCap1712
July 16, 2026 15:19
Test Results401 tests +176 384 ✅ +164 3m 12s ⏱️ + 2m 20s For more details on these failures, see this check. Results for commit fe82364. ± Comparison against base commit 2a8e235. This pull request removes 153 and adds 329 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please double check if this is the right way to do these things - I've aped what I saw @MonkeyDo do for the combined strings.
For the policy docs, ideally we should fix all these to have strings as variables, but before doing it like we have done elsewhere (which keeps the
<a>in the string and only replaces the URL itself) I thought I'd ask if it can be done as in the tsx files and have the whole<a>element replaced by a variable?