Conversation
|
Does this include changes to address all comments made on the previous PR? |
Sophist-UK
left a comment
There was a problem hiding this comment.
I have checked and this does NOT include the comments I made on the previous PR #402. I was unhappy enough that having donated my time to try to help @nrth3rnlb improve his new plugin that he then voided that effort by closing the PR, but I consider it a further sign of disrespect that a new PR has been opened without those review comments having been dealt with.
I do not intend to spend my time repeating the same comments, but I recommend that this PR is NOT accepted until the previous review comments on the other PR are taken note of.
I have no idea what your bloody problem is. You seem to think that with your 50 years of programming experience, you’re something special. Your self-promotion just bores me. The fact is, you’ll be back on my block list just as quickly as I removed you from it at lunchtime today. By the way, you’re the only person on it. I hope I never hear from you again. |
This pull request introduces a new "Title Cleaner OST" plugin for MusicBrainz Picard, designed to remove soundtrack-related information from album titles using customizable regular expressions. It provides a user interface for configuring regex patterns, whitelists, and release type filters, along with a live test feature to preview changes. The changes include both the plugin's Python implementation and its Qt-based configuration UI.
Key changes:
New Plugin Implementation:
plugins/title_cleaner_ost/__init__.py, implementing the "Title Cleaner OST" plugin with:User Interface for Plugin Configuration:
plugins/title_cleaner_ost/title_cleaner_ost_config.ui, providing a Qt Designer-based configuration dialog with: