Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Extends the SDK update request shape for provider auth credentials to include
clientId,clientSecret, andscopes, which touches credential/secret handling (even though it’s just client-side mapping). Risk is limited to request serialization compatibility with the API.Overview
Adds support for updating OAuth credential fields via the generated SDK. The
*AuthCredentialsUpdateBodytypes and mappers now acceptclient_id,client_secret, andscopes(string array) in addition toname,description, andmetadata.This change is applied consistently across both API versions (
mt_2025_01_01_dashboardandmt_2026_01_01_magnetar) and across dashboard/management and non-instance provider-deployment auth-credential update resources.Reviewed by Cursor Bugbot for commit 787fc51. Bugbot is set up for automated code reviews on this repo. Configure here.