Draft
Conversation
opqdonut
reviewed
Mar 13, 2026
Member
opqdonut
left a comment
opqdonut
left a comment
There was a problem hiding this comment.
I happened to bump into this PR only now. Looks ok, but I would appreciate a commend and some benchmark results to prove the perf improvement.
| `(let [~@bs] | ||
| (fn [~arg] ~body))))) | ||
|
|
||
| #?(:clj (defmacro OR |
Member
There was a problem hiding this comment.
please add a comment about the leaner bytecode thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some ideas for performance improvements to
malli.impl.util. These were all by eye, let me know if they don't seem obviously better and I will look into it.The
OR/ANDmacro compiles to leaner JVM bytecode if you're returning booleans, originally developed in collaboration with @alexander-yakushev.