Conversation
…#118) * Feat: implement inSearchBox function and enhance mouse click handling in search mode * Refactor onMouseClick to streamline search handling and remove redundant comments
* Feat: enhance package detail display with version support and improve detail filtering * Feat: update ShowPackage function to accept a single version string parameter
* Feat: enhance package detail display to include repository origins * Feat: enhance repository origin handling and deduplicate entries in formatPolicyOrigins * Feat: implement repository origin filter and enhance search functionality * Feat: enhance enrichedDetailInfo to display package origins * Feat: enhance query tokenization and improve repository origin handling * Feat: enhance search result handling with origin filtering and display * Feat: enhance query tokenization to support single and double quotes for filtering
* Feat: improve markers visibility by adding essential status and updating package list display * Refactor: remove TestRenderPackageListEssentialBadge test case * Feat: enhance enrichedDetailInfo function to filter out both Status and Essential lines from apt-cache output * Feat: enhance enrichedDetailInfo function to derive essential state from apt-cache output * Feat: add manually installed status to search result packages * Feat: add essential status to search results in onSearchResultLoaded function * Feat: propagate essential status in onPackageDetailLoaded and add corresponding test
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+406
to
411
| // Preserve Origins loaded from bulk package files; ParseShowEntry | ||
| // has no access to the apt lists so it always returns an empty slice. | ||
| if existing, ok := a.infoCache[msg.name]; ok && len(existing.Origins) > 0 { | ||
| pi.Origins = existing.Origins | ||
| } | ||
| a.infoCache[msg.name] = pi |
Contributor
There was a problem hiding this comment.
apt-cache show name=version, but the cache is still keyed only by package name. Selecting a specific installed or older version can overwrite infoCache[name] with that version's metadata, and later search/list enrichment uses it for the package regardless of which version is being displayed. Packages with multiple available versions can then show or filter with stale section, size, version, or origin data.
Comment on lines
+213
to
+234
| func replaceRepoToken(q string, repo string) string { | ||
| var quoted string | ||
| if strings.ContainsRune(repo, ' ') { | ||
| quoted = `repo:"` + repo + `"` | ||
| } else { | ||
| quoted = "repo:" + repo | ||
| } | ||
|
|
||
| tokens := splitQueryTokens(q) | ||
| found := false | ||
| for i, t := range tokens { | ||
| lower := strings.ToLower(t) | ||
| if strings.HasPrefix(lower, "repo:") || strings.HasPrefix(lower, "origin:") { | ||
| tokens[i] = quoted | ||
| found = true | ||
| break | ||
| } | ||
| } | ||
| if !found { | ||
| tokens = append(tokens, quoted) | ||
| } | ||
| return strings.Join(tokens, " ") |
Contributor
There was a problem hiding this comment.
replaceRepoToken wraps origins containing spaces in quotes but does not escape quotes in the origin value. The filter tokenizer treats quotes as delimiters and has no escape handling, so a custom/local repository origin containing " is split into a truncated repo: value plus extra free text. Selecting that origin from the dropdown will produce incorrect or empty results.
Bumps [charm.land/bubbletea/v2](https://github.com/charmbracelet/bubbletea) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/charmbracelet/bubbletea/releases) - [Commits](charmbracelet/bubbletea@v2.0.6...v2.0.7) --- updated-dependencies: - dependency-name: charm.land/bubbletea/v2 dependency-version: 2.0.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR adds repository origin filtering to aptui 0.9, including a new
repo:/origin:filter token, an origin dropdown overlay (okey), origin tracking extracted from APT list filenames, version-specificapt-cache showcalls, and Essential-flag propagation into the detail panel.keypress_repo_filter.goandrepolist.goimplement the repo-origin dropdown;originFromListFilenamederives human-readable origins from/var/lib/apt/lists/filenames and merges them intoPackageInfo.Origins.ShowPackagenow passesname=versiontoapt-cache showso the detail panel reflects the exact selected version;ListVersionsgainsLANG=Cfor reliable output parsing.Confidence Score: 4/5
Safe to merge after fixing the two mouse-blocking and scroll-offset issues; the core origin-filtering logic is correct.
Mouse events are not blocked while the repo-filter overlay is active: scroll wheel events scroll the underlying package list and clicks can change selection or switch tabs while the dropdown is displayed. Separately, reopening the dropdown when a repo: filter is already active restores the cursor index but not the scroll offset, so the highlighted row is invisible if the matching origin is not on the first page.
internal/app/update.go (mouse-event guard) and internal/app/keypress_repo_filter.go (initial scroll adjustment in openRepoFilter)
Reviews (2): Last reviewed commit: "build(deps): bump charm.land/bubbletea/v..." | Re-trigger Greptile